Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44893 )
Change subject: mb/google/zork: update GPIO config for berknip ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44893/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/berknip/gpio.c:
https://review.coreboot.org/c/coreboot/+/44893/1/src/mainboard/google/zork/v... PS1, Line 13: /* DMIC_SEL */ GPIO_5 should also be configured as PAD_NC since it is unused on berknip.
https://review.coreboot.org/c/coreboot/+/44893/1/src/mainboard/google/zork/v... PS1, Line 43: You will also need a default berkbip_gpio_set_stage_ram[] and configure GPIO_4 and GPIO_5 as PAD_NC. This will have to be returned for board versions > 2 below.
https://review.coreboot.org/c/coreboot/+/44893/1/src/mainboard/google/zork/v... PS1, Line 64: *size = 0; Here, instead of 0 and NULL, you will have to return sizeof(berkbip_gpio_set_stage_ram) and berkbip_gpio_set_stage_ram.