Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38947 )
Change subject: mb/hatch + soc/intel/cannonlake: Enable TetonGlacierMode on hatch ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38947/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38947/1//COMMIT_MSG@9 PS1, Line 9: Enabling TetonGlacierMode allows for reconfiguring the PCIe lanes at runtime for hybrid drives. Please wrap the line after 75 or 72 characters.
https://review.coreboot.org/c/coreboot/+/38947/1/src/soc/intel/cannonlake/ch... File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/38947/1/src/soc/intel/cannonlake/ch... PS1, Line 245: // Enables support for Teton Glacier hybrid storage device For consistency, please use C89 style comments.