Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37781 )
Change subject: soc/intel/tigerlake: Update ACPI files
......................................................................
Patch Set 18: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/37781/17/src/soc/intel/tigerlake/ac...
File src/soc/intel/tigerlake/acpi/pch_clock_ctl.asl:
https://review.coreboot.org/c/coreboot/+/37781/17/src/soc/intel/tigerlake/ac...
PS17, Line 20: #define PID_ICLK 0xAD
can u move this into pcr_ids. […]
Ack
https://review.coreboot.org/c/coreboot/+/37781/17/src/soc/intel/tigerlake/ac...
PS17, Line 70: RAOW(CLK1, !B_ICLK_PCR_REQUEST, Arg1<<1)
~B_ICLK_PCR_REQUEST
Ack
https://review.coreboot.org/c/coreboot/+/37781/17/src/soc/intel/tigerlake/ac...
File src/soc/intel/tigerlake/acpi/pmc.asl:
https://review.coreboot.org/c/coreboot/+/37781/17/src/soc/intel/tigerlake/ac...
PS17, Line 29: 0x1880
replace with define
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37781
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib82156830273c2937f5f02713ed7dd27da41c857
Gerrit-Change-Number: 37781
Gerrit-PatchSet: 18
Gerrit-Owner: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Wed, 15 Jan 2020 05:46:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment