[coreboot-gerrit] Change in coreboot[master]: soc/sifive/fu540: add code for spi and map flash to memory spaces

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33055 )

Change subject: soc/sifive/fu540: add code for spi and map flash to memory spaces
......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33055/9/src/soc/sifive/fu540/spi.c 
File src/soc/sifive/fu540/spi.c:

https://review.coreboot.org/c/coreboot/+/33055/9/src/soc/sifive/fu540/spi.c@... 
PS9, Line 78: 			spi_tx(spictrl, out);
> I tried to look at the spi-generic.h file, both xfer() and xfer_vector() work in full duplex. […]

I'm sorry that's not what I was trying to explain.

Check the other xfer impementations.

They all transmit "bytesouts" bytes and discard the received byte,
then they receive "bytesin" bytes by transmitting 0.
It's done like in the code below.

It never touches din and dout at the same time.