Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48416 )
Change subject: mb/intel/adlrvp_p: Support VBT for LP4, LP5 and DDR5 SKUs
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48416/3/src/mainboard/intel/adlrvp/...
File src/mainboard/intel/adlrvp/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48416/3/src/mainboard/intel/adlrvp/...
PS3, Line 23:
can we add like this […]
What is the structure that you are trying to follow here? What will be supplying vbt_lp4.bin?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48416
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8795cc67d87429eddb31328f1e2a90c346b53533
Gerrit-Change-Number: 48416
Gerrit-PatchSet: 4
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 08 Dec 2020 06:53:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment