Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34946 )
Change subject: WIP: add src/mainboard/hp/spectre_x360_13t_ae000 port ......................................................................
Patch Set 24:
(4 comments)
Some suggestions so that you can understand what romstage looks like better
https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/memory.h:
PS24: This isn't needed as you don't use variants
https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/memory.c:
PS24: This can be inside romstage.c
https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... File src/mainboard/hp/spectre_x360_13t_ae000/romstage.c:
https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... PS24, Line 53: memory_params once you move the memory data into this file, this struct can be removed. Uninitialized fields are memset'd to zero on line 58, btw.
https://review.coreboot.org/c/coreboot/+/34946/24/src/mainboard/hp/spectre_x... PS24, Line 75: mem_cfg->MemorySpdPtr10 = 0; Always run this for now, as bringing up one channel at a time is easier.