[coreboot-gerrit] [L] Change in coreboot[main]: mb/asus/h61-series: Add P8H67-I DELUXE variant

[Nicholas Chin (Code Review)]

Attention is currently required from: Angel Pons, Riku Viitanen.

Nicholas Chin has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85832?usp=email )

Change subject: mb/asus/h61-series: Add P8H67-I DELUXE variant
......................................................................

Patch Set 7: Code-Review+1

(6 comments)

File src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/early_init.c:

https://review.coreboot.org/c/coreboot/+/85832/comment/c686895b_1da4fd29?usp... :
PS7, Line 8: PCI_DEV(0, 0x1f, 0), 0x82, 0x3f00
Could be replaced with macros in `sb/intel/bd82x6x/pch.h`:
```suggestion
    pci_write_config16(PCH_LPC_DEV, LPC_EN, CNF2_LPC_EN | CNF1_LPC_EN
    		| MC_LPC_EN | KBC_LPC_EN | GAMEH_LPC_EN | GAMEL_LPC_EN);```

https://review.coreboot.org/c/coreboot/+/85832/comment/4ffc9c52_cd3490c6?usp... :
PS7, Line 9: PCI_DEV(0, 0x1f, 0), 0x80, 0x0010
Same here:
```suggestion
    pci_write_config16(PCH_LPC_DEV, LPC_IO_DEC, 0x0010);
```
Also, since COMB_LPC_EN isn't enabled in the LPC_EN register, setting a value for the COMB Decode Range (bits 6:4) to 0x1 (decode 0x2f8 - 0x2ff to LPC) wouldn't have any effect.

File src/mainboard/asus/h61-series/variants/p8h67-i_deluxe/overridetree.cb:

PS7: 
Add SPDX header

https://review.coreboot.org/c/coreboot/+/85832/comment/d9f763b1_e3146bd6?usp... :
PS7, Line 2: register "gpu_dp_b_hotplug" = "4"
           : 	register "gpu_dp_d_hotplug" = "4"
Move under igd

https://review.coreboot.org/c/coreboot/+/85832/comment/dcf770e1_23e392a3?usp... :
PS7, Line 40: subsystemid 0x1043 0x848d
It looks like it is possible to use a `subsystemid 0xnnnn 0xnnnn inherit` and then still specify a subsystemid for an individual device which will override it (refer to the `subsystem_device` fields in the generated `static.c` file). That way all the `subsystemid 0x1043 0x844d` lines could be dropped and this one could be kept in place.

https://review.coreboot.org/c/coreboot/+/85832/comment/4160f17d_f3e30f5b?usp... :
PS7, Line 62: device ref pci_bridge off end
Defaults to off in chipset devicetree and can be removed from the overridetree