Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44809 )
Change subject: util/ifdtool: Add platform specific quirks for ADL/ICL/JSL/TGL ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44809/2/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/44809/2/util/ifdtool/ifdtool.c@1453 PS2, Line 1453: " adl - Alder Lake\n" : " aplk - Apollo Lake\n" : " cnl - Cannon Lake\n" : " glk - Gemini Lake\n" : " icl - Ice Lake\n" : " jsl - Jasper Lake\n" : " sklkbl - Skylake/Kaby Lake\n" : " tgl - Tiger Lake\n" : " -S | --setpchstrap Write a PCH strap\n" minor nit: would be nice to line these up as well: "adl - Alder Lake\n" "aplk - Apollo Lake\n" "cnl - Cannon Lake\n" "glk - Gemini Lake\n" "icl - Ice Lake\n" "jsl - Jasper Lake\n" "sklkbl - Skylake/Kaby Lake\n"