Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33116 )
Change subject: Kconfig: Enable CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM based on CONFIG_STAGE_RAMSTAGE
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33116/3/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/#/c/33116/3/src/Kconfig@281
PS3, Line 281: config CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM
What about this Kconfig entry? You are adding the same one below.
https://review.coreboot.org/#/c/33116/3/src/Kconfig@1214
PS3, Line 1214: ARCH_X86
This option isn't really dependent on x86.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45e894ad335a4661cc7916b3768e1614a038b31c
Gerrit-Change-Number: 33116
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 31 May 2019 16:41:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment