Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48644 )
Change subject: soc/intel/cannonlake: Change mainboard_silicon_init_params argument
......................................................................
Patch Set 2: Code-Review+1
LGTM, makes it consistent with the way romstage is handled too
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48644
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d67264e22df32b9210ce88b99d6a7a4f6b97ffb
Gerrit-Change-Number: 48644
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 15 Dec 2020 19:29:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment