[coreboot-gerrit] Change in ...coreboot[master]: mb/google/octopus: rename get_board_sku and make it overridable

[Marco Chen (Code Review)]

Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33448 )

Change subject: mb/google/octopus: rename get_board_sku and make it overridable
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33448/1/src/mainboard/google/octopus/mainboa... 
File src/mainboard/google/octopus/mainboard.c:

https://review.coreboot.org/#/c/33448/1/src/mainboard/google/octopus/mainboa... 
PS1, Line 121: __weak
> Hi Aaron, […]

I had suggested partners to refer how nami's implementation was and I support to leverage the same function name so partners later are easy to align and refer example codes.

Regarding weak, when I gave +1 I had the same concern with Kevin about allowing variants to override the function implementation even though Octopus would only have one impl. of managing SKU ID. But it would be good to have consistent.