Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson. Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/53916 )
Change subject: soc/amd/picasso/root_complex: move DPTC_TOTAL_UPDATE_PARAMS out of enum ......................................................................
soc/amd/picasso/root_complex: move DPTC_TOTAL_UPDATE_PARAMS out of enum
The other enum entries are control IDs for the ALIB_FUNCTION_DYNAMIC_POWER_THERMAL_CONFIG ALIB function while DPTC_TOTAL_UPDATE_PARAMS is the total number of configuration settings that will get passed as parameter in the ALIB call, so it shouldn't be part of that enum.
TEST=Timeless build for Mandolin results in identical binary.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I0cb9e9d2ba579a74d916011b4ead71cc86d69a24 --- M src/soc/amd/picasso/root_complex.c 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/53916/1
diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index 47b3a43..932ca76 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -23,9 +23,10 @@ SUSTAINED_POWER_LIMIT_PARAM_ID = 0x5, FAST_PPT_LIMIT_PARAM_ID = 0x6, SLOW_PPT_LIMIT_PARAM_ID = 0x7, - DPTC_TOTAL_UPDATE_PARAMS = 4, };
+#define DPTC_TOTAL_UPDATE_PARAMS 4 + struct dptc_param { uint8_t id; uint32_t value;