Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34137 )
Change subject: soc/intel/common/lpss: Add function to check for a LPSS controller
......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34137/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34137/8//COMMIT_MSG@10
PS8, Line 10: . S
, since ?
Done
https://review.coreboot.org/c/coreboot/+/34137/8//COMMIT_MSG@15
PS8, Line 15: implement strong of soc_lpss_controllers_list
implement soc_lpss_controllers_list
Done
https://review.coreboot.org/c/coreboot/+/34137/7/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/lpss.h:
https://review.coreboot.org/c/coreboot/+/34137/7/src/soc/intel/common/block/...
PS7, Line 45: for
nit: of
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34137
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f5bb268fc581280bb1b87b6b175a0299a24a44a
Gerrit-Change-Number: 34137
Gerrit-PatchSet: 10
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Fri, 26 Jul 2019 14:32:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment