Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25660 )
Change subject: sb/intel/bd82x6x: Fix flashconsole after lockdown
......................................................................
Patch Set 6:
(2 comments)
I addressed comments to PS4 and rebased the patch on master.
https://review.coreboot.org/#/c/25660/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/25660/4//COMMIT_MSG@7
PS4, Line 7: if flashconsole is enabled
This makes the line too long, should be <= 65 chars (which is […]
Done
https://review.coreboot.org/#/c/25660/4/src/southbridge/intel/bd82x6x/lpc.c
File src/southbridge/intel/bd82x6x/lpc.c:
https://review.coreboot.org/#/c/25660/4/src/southbridge/intel/bd82x6x/lpc.c@...
PS4, Line 869: * ramstage, whitelist it here. */
Sorry for nitpicking, please use one of the comment styles from [1]. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25660
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib802d7ee32f1fb0a68a84b0280480dcaefa9831f
Gerrit-Change-Number: 25660
Gerrit-PatchSet: 6
Gerrit-Owner: Dan Elkouby
streetwalkermc@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Dan Elkouby
streetwalkermc@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Tue, 07 May 2019 00:38:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment