Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35367 )
Change subject: mb/ocp/monolake: Add GPIO table and initialize ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35367/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35367/1//COMMIT_MSG@9 PS1, Line 9: Add GPIO table for Monolake to initialize GPIOs. why?
https://review.coreboot.org/c/coreboot/+/35367/1//COMMIT_MSG@10 PS1, Line 10: Tested on Monolake how?
https://review.coreboot.org/c/coreboot/+/35367/1/src/mainboard/ocp/monolake/... File src/mainboard/ocp/monolake/romstage.c:
https://review.coreboot.org/c/coreboot/+/35367/1/src/mainboard/ocp/monolake/... PS1, Line 66: init_gpios(gpio_tables); why here and not in ramstage or early_romstage?