Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31837 )
Change subject: drivers/tpm: remove initialization call from Intel FSP2.0 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/31837/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31837/2//COMMIT_MSG@12 PS2, Line 12: src/drivers/tpm/tpm.c takes care of : initializing TPM (see Kconfig option TPM_INIT). So, were the devices getting initialized twice currently if VBOOT is not selected -- i.e. with TPM_INIT tpm_setup was done in romstage as well as in ramstage?
https://review.coreboot.org/#/c/31837/2//COMMIT_MSG@14 PS2, Line 14: TPM will be initialized whenever : verstage is executed, depending on how the device is configured There is actually one case which would fail with or without this change. When using VBOOT and RECOVERY_MRC_CACHE, tpm read/write occurs before tpm_setup with VBOOT_STARTS_IN_ROMSTAGE. So, that would fail since tpm_setup is not yet called.