View Change
2 comments:
Commit Message:
Patch Set #2, Line 12:
src/drivers/tpm/tpm.c takes care of
initializing TPM (see Kconfig option TPM_INIT).
So, were the devices getting initialized twice currently if VBOOT is not selected -- i.e. with TPM_INIT tpm_setup was done in romstage as well as in ramstage?
Patch Set #2, Line 14:
TPM will be initialized whenever
verstage is executed, depending on how the device is configured
There is actually one case which would fail with or without this change. When using VBOOT and RECOVERY_MRC_CACHE, tpm read/write occurs before tpm_setup with VBOOT_STARTS_IN_ROMSTAGE. So, that would fail since tpm_setup is not yet called.
To view, visit change 31837. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ba91c275c33245be61041cb592e52f861dbafe6
Gerrit-Change-Number: 31837
Gerrit-PatchSet: 2
Gerrit-Owner: Joel Kitching <kitching@google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Joel Kitching <kitching@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Tue, 12 Mar 2019 04:57:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment