build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46661 )
Change subject: sc7180: Add Modem region in memlayout to avoid modem cleanup in Secboot reboot. ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46661/4/src/soc/qualcomm/sc7180/car... File src/soc/qualcomm/sc7180/carve_out.c:
https://review.coreboot.org/c/coreboot/+/46661/4/src/soc/qualcomm/sc7180/car... PS4, Line 16: switch (modem_id) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/46661/4/src/soc/qualcomm/sc7180/soc... File src/soc/qualcomm/sc7180/soc.c:
https://review.coreboot.org/c/coreboot/+/46661/4/src/soc/qualcomm/sc7180/soc... PS4, Line 21: if (soc_modem_carve_out(&start, &end)) { braces {} are not necessary for single statement blocks