Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33794 )
Change subject: libpayload/libc: Use size_t for lengths and indices
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33794/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/33794/2//COMMIT_MSG@10
PS2, Line 10: this fixes several integer conversion and sign comparison warnings.
Do you know, if there is a size penalty for these changes?
Generally no - I tested compiling some of these functions in various architectures on godbolt.org, and the generated code is either identical or slightly smaller.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33794
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5658b19f990de4596a602b36d9533b1ca96ad947
Gerrit-Change-Number: 33794
Gerrit-PatchSet: 2
Gerrit-Owner: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 22 Jul 2019 18:33:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment