build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46510 )
Change subject: mrc_cache: Move mrc_cache_*_hash functions into mrc_cache driver ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46510/1/src/drivers/mrc_cache/mrc_c... File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/46510/1/src/drivers/mrc_cache/mrc_c... PS1, Line 189: // NOTE: we need to create the hash from both data and metadata values code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46510/1/src/drivers/mrc_cache/mrc_c... PS1, Line 190: if (CONFIG(MRC_SAVE_HASH_IN_TPM) && !mrc_cache_verify_hash(data, data_size)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46510/1/src/drivers/mrc_cache/mrc_c... PS1, Line 190: if (CONFIG(MRC_SAVE_HASH_IN_TPM) && !mrc_cache_verify_hash(data, data_size)) please, no spaces at the start of a line