Attention is currently required from: Angel Pons, Patrick Rudolph. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59519 )
Change subject: security/intel/txt: Fix HEAP_ACM format depending on number of ACMs in CBFS ......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59519/comment/bac1f79d_20542163 PS3, Line 7: Fix
Sure. With this comment I meant to say that the commit message should also contain this information.
Added verbose explanation in the commit message
File src/security/intel/txt/ramstage.c:
https://review.coreboot.org/c/coreboot/+/59519/comment/ee251bfb_5466e80f PS2, Line 271: * FIXME: these calculations handle the lack of SINIT ACM in CBFS.
maybe we can use 2 structs, one with NumAcms == 1 and one with NumAcms == 2. […]
Used two structures as suggested
https://review.coreboot.org/c/coreboot/+/59519/comment/e10f6165_f8fc61b9 PS2, Line 278: size
this will fix the HEAP_EXTDATA_TYPE_ACM size for case NumAcms == 1, but it then will not point to HE […]
Right. Now with two separate HEAP_ACM structures it works fine. Tested with and without SINIT ACM in CBFS.