[coreboot-gerrit] Change in coreboot[master]: mb/asrock/h110m: fix VR domains configuration

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35067 )

Change subject: mb/asrock/h110m: fix VR domains configuration
......................................................................

mb/asrock/h110m: fix VR domains configuration

1) VR domains current limit Icc max for Sky/Kaby Lake S is set based
on the processor TDP [1]. Updates information about this

2) Sets VR voltage limit to 1.52V, as described in the datasheets [2,3]

[1] Change-Id: I303c5dc8ed03e9a98a834a2acfb400022dfc2fde
[2] page 112-119, 6th Generation Intel(R) Processor Families
    for S-Platforms, Volume 1 of 2, Datasheet, August 2018.
    Document Number: 332687-008EN
[3] 7th Generation Intel(R) Processor Families for S Platforms and
    Intel(R) Core(TM) X-Series Processor Family Datasheet, Volume 1,
    December 2018, Document Number: 335195-003

Change-Id: I6e1aefde135ffce75a5d837348595aa20aff0513
Signed-off-by: Maxim Polyakov 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35067
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Georgi 
---
M src/mainboard/asrock/h110m/devicetree.cb
1 file changed, 6 insertions(+), 5 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved

diff --git a/src/mainboard/asrock/h110m/devicetree.cb b/src/mainboard/asrock/h110m/devicetree.cb
index 3067ffe..5370568 100644
--- a/src/mainboard/asrock/h110m/devicetree.cb
+++ b/src/mainboard/asrock/h110m/devicetree.cb
@@ -89,9 +89,10 @@
    #| Psi4Enable     | 1     | 1     | 1           | 1           | 1     |
    #| ImonSlope      | 0     | 0     | 0           | 0           | 0     |
    #| ImonOffset     | 0     | 0     | 0           | 0           | 0     |
-	#| IccMax         | 7A    | 34A   | 34A         | 35A         | 35A   |
+	#| IccMax*        | 0     | 0     | 0           | 0           | 0     |
    #| VrVoltageLimit | 1.52V | 1.52V | 1.52V       | 1.52V       | 1.52V |
    #+----------------+-------+-------+-------------+-------------+-------+
+	# * - is set automatically for the KBL-S/KBL-DT CPUs in the vr_config.c
    register "domain_vr_config[VR_SYSTEM_AGENT]" = "{
    	.vr_config_enable = 1, \
    	.psi1threshold = 0x50, \
@@ -102,7 +103,7 @@
    	.imon_slope = 0x0, \
    	.imon_offset = 0x0, \
    	.icc_max = 0x0, \
-		.voltage_limit = 0x0 \
+		.voltage_limit = 1520 \
    }"

register "domain_vr_config[VR_IA_CORE]" = "{
@@ -115,7 +116,7 @@
    	.imon_slope = 0x0, \
    	.imon_offset = 0x0, \
    	.icc_max = 0x0, \
-		.voltage_limit = 0x0 \
+		.voltage_limit = 1520 \
    }"

register "domain_vr_config[VR_GT_UNSLICED]" = "{
@@ -128,7 +129,7 @@
    	.imon_slope = 0x0, \
    	.imon_offset = 0x0, \
    	.icc_max = 0x0 ,\
-		.voltage_limit = 0x0 \
+		.voltage_limit = 1520 \
    }"

register "domain_vr_config[VR_GT_SLICED]" = "{
@@ -141,7 +142,7 @@
    	.imon_slope = 0x0, \
    	.imon_offset = 0x0, \
    	.icc_max = 0x0, \
-		.voltage_limit = 0x0 \
+		.voltage_limit = 1520 \
    }"

register "EnableLan" = "0"