Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40525 )
Change subject: soc/mediatek/mt8183: Use term settings for high DRAM frequency ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40525/9/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_init_setting.c:
https://review.coreboot.org/c/coreboot/+/40525/9/src/soc/mediatek/mt8183/dra... PS9, Line 1378: * dramc init using dramc_setting_DDRxxx() to overwrite the default settings. Please improve the wording and spelling. Maybe:
The default dramc settings were tuned at a frequency of 3200Mbps. For other frequencies darmc init uses dramc_setting_DDRxxx() to override the default settings.
I am not sure about the first meaning though.
https://review.coreboot.org/c/coreboot/+/40525/9/src/soc/mediatek/mt8183/dra... PS9, Line 1379: */ Please use the allowed comment styles.
https://doc.coreboot.org/coding_style.html#commenting