Attention is currently required from: Jason Glenesk, Marshall Dawson, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63259 )
Change subject: mb/amd/chaisue/port_descriptors: clean up variable names
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63259/comment/e85f1572_02a7df25
PS1, Line 7: chaisue
chausie
Patchset:
PS1:
might be a good idea to push a similar patch for majolica. the soc name was added in the mandolin code to handle the different cases for picasso vs. dali and it got copied over from there on
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63259
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cc854f4c60707c7fec5cd7fef1c4550883cd45a
Gerrit-Change-Number: 63259
Gerrit-PatchSet: 1
Gerrit-Owner: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 31 Mar 2022 14:58:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment