Attention is currently required from: Sridhar Siricilla, Tim Wawrzynczak, Arthur Heymans.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63141 )
Change subject: soc/intel/alderlake/pmc_descriptor.c: Don't depend on FMAP
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS2:
Thanks Arthur 😊 I had forgotten about the FMAP_SECTION_*... macros,
File src/soc/intel/alderlake/bootblock/pmc_descriptor.c:
https://review.coreboot.org/c/coreboot/+/63141/comment/2fd39654_32bcb5d5
PS2, Line 62: if (cpu_get_cpuid() != CPUID_ALDERLAKE_A0)
: return;
I would probably keep this as the first early return?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63141
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d180353bfd69601ce03feb59101fb425859e779
Gerrit-Change-Number: 63141
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 28 Mar 2022 17:40:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment