Jacob Garber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32795 )
Change subject: {arch,cpu}/x86, drivers/intel: Restore cpu_index error handling ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/#/c/32795/1/src/drivers/intel/fsp2_0/ppi/mp_serv... File src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c:
https://review.coreboot.org/#/c/32795/1/src/drivers/intel/fsp2_0/ppi/mp_serv... PS1, Line 48: if (cpu_index() < 0)
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/32795/1/src/drivers/intel/fsp2_0/ppi/mp_serv... PS1, Line 48: if (cpu_index() < 0)
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/32795/1/src/drivers/intel/fsp2_0/ppi/mp_serv... PS1, Line 74: if (cpu_index() < 0)
code indent should use tabs where possible
Done
https://review.coreboot.org/#/c/32795/1/src/drivers/intel/fsp2_0/ppi/mp_serv... PS1, Line 74: if (cpu_index() < 0)
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/32795/1/src/drivers/intel/fsp2_0/ppi/mp_serv... PS1, Line 94: if (cpu_index() < 0)
please, no spaces at the start of a line
Done
https://review.coreboot.org/#/c/32795/1/src/drivers/intel/fsp2_0/ppi/mp_serv... PS1, Line 94: if (cpu_index() < 0)
code indent should use tabs where possible
Done