Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36908 )
Change subject: lib/fmap.c: Properly handle cache for !C_ENVIRONMENT_BOOTBLOCK ......................................................................
lib/fmap.c: Properly handle cache for !C_ENVIRONMENT_BOOTBLOCK
On platforms without C_ENVIRONMENT_BOOTBLOCK the first stage accessing FMAP is romstage. As on these platforms only romstage is expected to call setup_preram_cache() no further handling is needed.
Change-Id: I7d70585b0c076707e73e20c2ed3f11e4c9ffdf37 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/lib/fmap.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/36908/1
diff --git a/src/lib/fmap.c b/src/lib/fmap.c index 4b4179c..f0fae55 100644 --- a/src/lib/fmap.c +++ b/src/lib/fmap.c @@ -78,7 +78,7 @@ }
struct fmap *fmap = (struct fmap *)_fmap_cache; - if (!ENV_BOOTBLOCK) { + if (!ENV_BOOTBLOCK && CONFIG(C_ENVIRONMENT_BOOTBLOCK)) { /* NOTE: This assumes that for all platforms running this code, the bootblock is the first stage and the bootblock will make at least one FMAP access (usually from finding CBFS). */