[coreboot-gerrit] Change in coreboot[master]: mb/google/guybrush: Add devfn macros for devices on GPP bridge

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: Raul Rangel, Martin Roth, Furquan Shaikh.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55601 )

Change subject: mb/google/guybrush: Add devfn macros for devices on GPP bridge
......................................................................

Patch Set 1:

(1 comment)

File src/mainboard/google/guybrush/port_descriptors.c:

https://review.coreboot.org/c/coreboot/+/55601/comment/ec163510_af882602 
PS1, Line 29: PCIE_GPP_2_1_FUNC
> Shouldn't this be SD_DEVFN?

We are passing the device in device_number field and function in function_number field. I think FSP is constructing the BDF based on the individual fields. Also here is the definition in Cezanne FSP port_descriptors.h

uint32_t	device_number		:5;	// Desired root port device number
    uint32_t	function_number		:3;	// Desired root port function number