Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39401 )
Change subject: soc/intel/tigerlake: add support to read SPD data from SMBus ......................................................................
Patch Set 9:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39401/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39401/8//COMMIT_MSG@9 PS8, Line 9: JSLRVP
Jasper Lake RVP
Done
https://review.coreboot.org/c/coreboot/+/39401/8//COMMIT_MSG@12 PS8, Line 12: jslrvp
Jasper Lake RVP
Done
https://review.coreboot.org/c/coreboot/+/39401/6/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/meminit_jsl.h:
https://review.coreboot.org/c/coreboot/+/39401/6/src/soc/intel/tigerlake/inc... PS6, Line 20: #include <stdint.h>
Should be cleaned up in a separate commit.
Ack
https://review.coreboot.org/c/coreboot/+/39401/6/src/soc/intel/tigerlake/inc... PS6, Line 55: spd
SPD
Done
https://review.coreboot.org/c/coreboot/+/39401/6/src/soc/intel/tigerlake/mem... File src/soc/intel/tigerlake/meminit_jsl.c:
https://review.coreboot.org/c/coreboot/+/39401/6/src/soc/intel/tigerlake/mem... PS6, Line 109: spd_info->spd_spec.spd_smbus_address[i];
Fits into 96 characters?
Ack
https://review.coreboot.org/c/coreboot/+/39401/8/src/soc/intel/tigerlake/mem... File src/soc/intel/tigerlake/meminit_jsl.c:
https://review.coreboot.org/c/coreboot/+/39401/8/src/soc/intel/tigerlake/mem... PS8, Line 121: meminit_channels(mem_cfg, board_cfg, spd_data_ptr, half_populated);
can't u just call […]
Done