22 Dec
2017
22 Dec
'17
9:30 a.m.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/22972 )
Change subject: mainboard/hp: Add Eliteboot Revolve 810 G1 ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/22972/2/src/mainboard/hp/revolve_810_g1/roms... File src/mainboard/hp/revolve_810_g1/romstage.c:
https://review.coreboot.org/#/c/22972/2/src/mainboard/hp/revolve_810_g1/roms... PS2, Line 91: void *spd_file = cbfs_boot_map_with_leak("spd.bin", CBFS_TYPE_SPD,
please don't leak the file
I just follow the common way to read spd files from cbfs, see romstage.c of mb/lenovo/s230u and x1_carbon_gen1
--
To view, visit https://review.coreboot.org/22972
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba9c361591697e6a2b3b7b485f7f1649c2a83524
Gerrit-Change-Number: 22972
Gerrit-PatchSet: 2
Gerrit-Owner: Bill XIE persmule@gmail.com
Gerrit-Reviewer: Bill XIE persmule@gmail.com
Gerrit-Reviewer: Iru Cai mytbk920423@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 Dec 2017 09:30:04 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No