Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45336 )
Change subject: soc/intel/common/basecode: Add Intel common reset code ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45336/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45336/5//COMMIT_MSG@7 PS5, Line 7: soc/intel/common/block
(although reset is not any IP block but still a common place where we can refer both core and at […]
Ack
https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/... File src/soc/intel/common/block/reset/reset.c:
https://review.coreboot.org/c/coreboot/+/45336/7/src/soc/intel/common/block/... PS7, Line 34: !!
isn't one enough?
Ack