Shaunak Saha has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45053 )
Change subject: mb/google/volteer: Add settings for noise mitgation
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45053/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45053/3/src/mainboard/google/voltee...
PS3, Line 233: # Acoustic settings
: register "AcousticNoiseMitigation" = "1"
: register "SlowSlewRate[0]" = "2"
: register "SlowSlewRate[1]" = "2"
: register "SlowSlewRate[2]" = "2"
: register "SlowSlewRate[3]" = "2"
: register "FastPkgCRampDisable[0]" = "1"
: register "FastPkgCRampDisable[1]" = "1"
: register "FastPkgCRampDisable[2]" = "1"
: register "FastPkgCRampDisable[3]" = "1"
:
Yes, these changes should be made in the override tree for the variant.
Will use these in override cb files.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45053
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69a6453091bf607d3c5847c99bc077e6b7dbc639
Gerrit-Change-Number: 45053
Gerrit-PatchSet: 3
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Eric Herrmann
eherrmann@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Oct 2020 08:12:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment