Hello Joel Kitching,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/38417
to review the following change.
Change subject: vboot: Remove hard dependency on MISSING_BOARD_RESET ......................................................................
vboot: Remove hard dependency on MISSING_BOARD_RESET
Having a working board reset is certainly better when you're running vboot (because otherwise you'll hang when transitioning into recovery mode), but I don't think it should be strictly required, since it's still somewhat usable without. This is particularly important for certain test platforms that don't have a good way to reset but might still be useful for vboot testing/prototyping.
Change-Id: Ia765f54b6e2e176e2d54478fb1e0839d8cab9849 Signed-off-by: Julius Werner jwerner@chromium.org --- M src/security/vboot/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/38417/1
diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig index 787cdbe..bde3980 100644 --- a/src/security/vboot/Kconfig +++ b/src/security/vboot/Kconfig @@ -28,7 +28,6 @@ default n select VBOOT_LIB select VBOOT_MOCK_SECDATA if !TPM1 && !TPM2 - depends on !MISSING_BOARD_RESET help Enabling VBOOT will use vboot to verify the components of the firmware (stages, payload, etc).