Hello Mathew King, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37255
to look at the new patch set (#3).
Change subject: cr50 i2c: add error message reporting TPM IRQ timeout ......................................................................
cr50 i2c: add error message reporting TPM IRQ timeout
Various recent x86 SOCs have trouble registering short pulses generated by the H1 to indicate that it is ready for the next transaction.
This patch adds an error message to report this condition, which would greatly reduce the amount of guesswork when troubleshooting new platforms.
BUG=b:144002424
TEST=tried this code on the Drallion device exhibiting the problem, observed error messages in the coreboot log;
$ grep IRQ ap.log Cr50 i2c TPM IRQ timeout! Cr50 i2c TPM IRQ timeout! Cr50 i2c TPM IRQ timeout! Cr50 i2c TPM IRQ timeout! ...
Change-Id: I5f6ee3986bed58e12fd0ec8cecbf35f46c9263c2 Signed-off-by: Vadim Bendebury vbendeb@chromium.org --- M src/drivers/i2c/tpm/cr50.c 1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/37255/3