Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49005 )
Change subject: soc/mediatek/mt8192: pmic: update initial setting ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49005/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49005/4//COMMIT_MSG@10 PS4, Line 10: Otherwise, the current of vgpu will be abnormal. Can you please specify the normal and abnormal values?
https://review.coreboot.org/c/coreboot/+/49005/4/src/soc/mediatek/mt8192/mt6... File src/soc/mediatek/mt8192/mt6359p.c:
https://review.coreboot.org/c/coreboot/+/49005/4/src/soc/mediatek/mt8192/mt6... PS4, Line 93: {0x19DE, 0x1, 0x1, 6}, Add a comment behind it, what it does?