12 Jul
2021
12 Jul
'21
10:44 p.m.
Attention is currently required from: Ravi kumar, Taniya Das, Julius Werner, mturney mturney. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55079 )
Change subject: sc7180: Add target specific GPIO pin definitions ......................................................................
Patch Set 13:
(1 comment)
File src/soc/qualcomm/sc7180/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/55079/comment/f3533ab2_b2f2c4b0 PS13, Line 11: 0x1000 Why did we get rid of this macro? Are they not equivalent?
--
To view, visit https://review.coreboot.org/c/coreboot/+/55079
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd206e6bc9a549706e7a2c4bde0b7d5527ca6268
Gerrit-Change-Number: 55079
Gerrit-PatchSet: 13
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Taniya Das tdas@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Attention: Taniya Das tdas@codeaurora.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: mturney mturney mturney@codeaurora.org
Gerrit-Comment-Date: Mon, 12 Jul 2021 19:44:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment