Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41910 )
Change subject: arch/x86: Declare permanent_smi_handler() ......................................................................
Patch Set 4:
(4 comments)
Patch Set 3:
(1 comment)
Some hunks are not about the FADT advertisement. Which makes it hard to assess which cases of `if(CONFIG(HAVE_SMI_HANDLER))` should be updated with this patch and which shouldn't. For instance, there are several instances that were not updated in amd chipset code that configure the APM_CNT port. Will they be updated later? Do they need an update at all?
Thanks, there are indeed some hunks here I am not so sure about. I will make this change only touch FADT advertisement, maybe move to CB:36828 for further discussion?
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/lpc.c:
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/bd82x... PS4, Line 839: if (permanent_smi_handler()) { Might be a mistake here.
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801ix/i82801ix.c:
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/i8280... PS4, Line 207: if (!permanent_smi_handler()) Need to figure out the logic in the original work.
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/i8280... File src/southbridge/intel/i82801jx/i82801jx.c:
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/i8280... PS4, Line 206: if (!permanent_smi_handler()) Need to figure out the logic in the original work.
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/lpc.c:
https://review.coreboot.org/c/coreboot/+/41910/4/src/southbridge/intel/ibexp... PS4, Line 732: if (permanent_smi_handler()) { Might be a mistake here.