Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46683 )
Change subject: nb/intel/haswell/early_init.c: Remove invalid register writes
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46683/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46683/4//COMMIT_MSG@9
PS4, Line 9: 0x6120
I've updated the commit message.
Please mention as many details as possible. For instance that the MRC
was checked and we know that nothing consumes the SSKPD value. Also that
no documentation mentions MCHBAR+0x6120. (Not the same as reserved.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21d9656a7595d47ac8648c08d223b7cbafd213c3
Gerrit-Change-Number: 46683
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 24 Oct 2020 20:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment