[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Adding Kconfig option to disable the eMMC contr...

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30614 )

Change subject: soc/intel/cannonlake: Adding Kconfig option to disable the eMMC controller
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/30614/2/src/soc/intel/cannonlake/acpi/scs.as... 
File src/soc/intel/cannonlake/acpi/scs.asl:

https://review.coreboot.org/#/c/30614/2/src/soc/intel/cannonlake/acpi/scs.as... 
PS2, Line 30: #
> yes, those bits represents  […]

Well it should get evaluated for _ADR devices in general,
not sure about absent _ADR devices. Though, if there is
no rule to ignore _STA, that sounds like a bug in the OS.

Without _STA, OSPM has to assume the device is present.
I trust you that you tested this in the past, but I'd
still want to see the code to avoid misunderstandings.