Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37487 )
Change subject: program.ld: Qualify .bss linking with ENV_EARLY_RAM ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37487/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37487/1//COMMIT_MSG@10 PS1, Line 10: location across early stages, and not necessarily within the
I am not the one giving -2/+2 on this question, but I'll give my opinions anyway. […]
a) Agree. b) I think you're advocating for cleaner elfs/stages, and using NO_XIP_EARLY_STAGES work. (I'm not up on ARCH_ARM.) c) I'm late on starting S3 work, however I'm presuming the PSP still overwrites my initial stage on each cycle and that must be reserved to avoid corrupting OS memory. After the 1st stage, i.e. in a bootblock->romstage scenario, I don't get cbmem until romstage. But if bootblock loads a non-xip romstage into DRAM, that clobbers OS memory, it seems to me. That's why I inferred that NO_XIP_EARLY_STAGES must be using all CAR and no DRAM. It would explain why it's not currently reserved, i.e. it would simply disappear at teardown.