Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/18548 )
Change subject: nb/intel/i945: Programm CxODT value for each channel ......................................................................
Patch Set 28:
(6 comments)
https://review.coreboot.org/c/coreboot/+/18548/26//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/18548/26//COMMIT_MSG@10 PS26, Line 10:
The commit message should be more elaborate.
Done
https://review.coreboot.org/c/coreboot/+/18548/28//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/18548/28//COMMIT_MSG@9 PS28, Line 9: programm program
https://review.coreboot.org/c/coreboot/+/18548/28//COMMIT_MSG@9 PS28, Line 9: raison reason :-)
https://review.coreboot.org/c/coreboot/+/18548/28//COMMIT_MSG@10 PS28, Line 10: eually equally
https://review.coreboot.org/c/coreboot/+/18548/28//COMMIT_MSG@10 PS28, Line 10: for drop "for"
https://review.coreboot.org/c/coreboot/+/18548/26/src/northbridge/intel/i945... File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/18548/26/src/northbridge/intel/i945... PS26, Line 2445: if (!(sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED &&
Could be a clean-up patch before this one.
Done