23 Feb
2019
23 Feb
'19
8:12 p.m.
mikeb mikeb has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31449 )
Change subject: src/device/Kconfig: Include the discrete VGA OpROM at config UI ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/31449/6/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/#/c/31449/6/src/arch/x86/Makefile.inc@52 PS6, Line 52: cbfs-files-$(CONFIG_VGA_BIOS_DGPU) += pci$(stripped_vgabios_dgpu_id).rom
we know, $(CONFIG_VGA_BIOS_DGPU) is `y`, here. Hmm, actually... […]
Good idea, thank you. Done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31449
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0a7bf0fe95c833cf3df0c7cb20fc27b6ab218c5a
Gerrit-Change-Number: 31449
Gerrit-PatchSet: 7
Gerrit-Owner: mikeb mikeb mikebdp2@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mikeb mikeb mikebdp2@gmail.com
Gerrit-CC: Arthur Heymans arthur@aheymans.xyz
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sat, 23 Feb 2019 20:12:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment