David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32087 )
Change subject: Patch an SSDT onto the end of the ACPI tables built for qemu-i440fx, and thus qemu-q35 also.
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32087/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32087/2//COMMIT_MSG@8
PS2, Line 8:
Please follow the gerrit guidelines and add a short topic. […]
Which guidelines? Maybe we need to add something (e.g. a pointer to a useful guide) about commit message style here:
https://doc.coreboot.org/lessons/lesson2.html
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32087
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4678b9adc8044a691c818527e2c16205f9b259e2
Gerrit-Change-Number: 32087
Gerrit-PatchSet: 5
Gerrit-Owner: John Looney
john.looney@gmail.com
Gerrit-Reviewer: John Looney
john.looney@gmail.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Apr 2019 20:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment