Attention is currently required from: Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32719 )
Change subject: drivers/apple: Add hybrid graphics driver ......................................................................
Patch Set 20:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/32719/comment/f768c93f_4a6f2b03 PS20, Line 15: ih hi
File src/drivers/apple/hybrid_graphics/acpi/gmux.asl:
https://review.coreboot.org/c/coreboot/+/32719/comment/7e7d2e65_b882c41f PS20, Line 12: 0x07FF, // Range Maximum Is the allocator aware of this fixed I/O resource?
File src/drivers/apple/hybrid_graphics/chip.h:
https://review.coreboot.org/c/coreboot/+/32719/comment/20d31180_a5d9fbb6 PS20, Line 14: gmux_indexed I'd make this a Kconfig option. This way, you don't need to access the devicetree to read/write gmux registers. In fact, it makes the code much simpler, since you no longer need to pass around any `struct device`.