Attention is currently required from: Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32719 ) Change subject: drivers/apple: Add hybrid graphics driver ...................................................................... Patch Set 20: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/32719/comment/f768c93f_4a6f2b03 PS20, Line 15: ih hi File src/drivers/apple/hybrid_graphics/acpi/gmux.asl: https://review.coreboot.org/c/coreboot/+/32719/comment/7e7d2e65_b882c41f PS20, Line 12: 0x07FF, // Range Maximum Is the allocator aware of this fixed I/O resource? File src/drivers/apple/hybrid_graphics/chip.h: https://review.coreboot.org/c/coreboot/+/32719/comment/20d31180_a5d9fbb6 PS20, Line 14: gmux_indexed I'd make this a Kconfig option. This way, you don't need to access the devicetree to read/write gmux registers. In fact, it makes the code much simpler, since you no longer need to pass around any `struct device`. -- To view, visit https://review.coreboot.org/c/coreboot/+/32719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22b66622cd2da0e9951ee726d650d204fbb8a5bc Gerrit-Change-Number: 32719 Gerrit-PatchSet: 20 Gerrit-Owner: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Wed, 03 Feb 2021 19:48:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment