Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38007 )
Change subject: sb/amd/cimx,hudson: Use common enable_usbdebug
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38007/1/src/southbridge/amd/pi/huds...
File src/southbridge/amd/pi/hudson/enable_usbdebug.c:
https://review.coreboot.org/c/coreboot/+/38007/1/src/southbridge/amd/pi/huds...
PS1, Line 35: return PCI_DEV(0, 0x16, 0);
The other code is using fn 2, what's going on?
Oh... good catch.
I think it's the rate-matching-hub thing (dropping OHCI) and fn 0 is correct once it is enabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38007
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id658001179898b94fdc179c539b92637af5095b8
Gerrit-Change-Number: 38007
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 03 Jan 2020 13:28:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment