Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37282 )
Change subject: soc/intel/common: Rename set_host_ready() to cse_set_host_ready()
......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37282/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37282/3//COMMIT_MSG@7
PS3, Line 7: soc/intel/common/block/cse: Rename set_host_ready() to cse_set_host_ready()
The line is too long, 72 is the maximum and <65 is recommended. […]
Done
https://review.coreboot.org/c/coreboot/+/37282/3//COMMIT_MSG@11
PS3, Line 11: 2. Additional debug messages are added
These are not even in set_host_ready(), please find a better […]
Done
https://review.coreboot.org/c/coreboot/+/37282/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/37282/3/src/soc/intel/common/block/...
PS3, Line 289: BIOS_ERR
Not an error message.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37282
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfcf1631cc37faacdea9ad84be55f5710104bad5
Gerrit-Change-Number: 37282
Gerrit-PatchSet: 4
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 26 Dec 2019 12:12:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment