Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30957 )
Change subject: superio/ite: Add it8528e
......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/#/c/30957/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/30957/4//COMMIT_MSG@7
PS4, Line 7: and use
Can be removed?
Done
https://review.coreboot.org/#/c/30957/4//COMMIT_MSG@9
PS4, Line 9: * Add SuperIO IT8528E
Could you extend the message with the discussion in the comments, that it’s actually an EC?
Done
https://review.coreboot.org/#/c/30957/4//COMMIT_MSG@10
PS4, Line 10:
Could you please also add the datasheet name/URL?
Done
https://review.coreboot.org/#/c/30957/4//COMMIT_MSG@13
PS4, Line 13: The serial works without CONFIG_CONSOLE_SERIAL.
Is that good or bad? Or do you mean, that it works under the OS?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30957
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72aa756e123d6f99d9ef4fe955c4b7f1be25d547
Gerrit-Change-Number: 30957
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 17 Jan 2019 12:42:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment