Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46432 )
Change subject: security/vboot: Make mrc_cache hash functions generic ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/antirol... File src/security/vboot/antirollback.h:
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/antirol... PS10, Line 61: MRC_RW_HASH_NV_INDEX nit: This is being introduced later.
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/mrc_cac... File src/security/vboot/mrc_cache_hash_tpm.c:
https://review.coreboot.org/c/coreboot/+/46432/10/src/security/vboot/mrc_cac... PS10, Line 12: mrc_cache_update_hash I think this and the function below should be updated to take in index as an argument.