Attention is currently required from: Ariel Otilibili.
Elyes Haouas has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85786?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: util/cbfstool: Replace 'unsigned long int' by 'unsigned long'
......................................................................
Patch Set 1:
(1 comment)
File util/cbfstool/flashmap/fmap.c:
https://review.coreboot.org/c/coreboot/+/85786/comment/20b406a9_219ef668?usp... :
PS1, Line 99: unsigned long offset = -1;
If it is unsigned, how it is = -1 ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85786?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If94e70778d0302552f151c31d3073524162faf9e
Gerrit-Change-Number: 85786
Gerrit-PatchSet: 1
Gerrit-Owner: Ariel Otilibili
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Patrick Georgi
patrick@coreboot.org
Gerrit-CC: ron minnich
rminnich@gmail.com
Gerrit-Attention: Ariel Otilibili
Gerrit-Comment-Date: Wed, 08 Jan 2025 02:56:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No