Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33203 )
Change subject: soc/intel/broadwell: Use common INTEL_SB SPI code
......................................................................
Patch Set 17:
Patch Set 16:
Hmmm, looks like a lot of definitions could be dropped from `soc/spi.h`?
Done in the respective CL using common features. Common L/UVSCC handling would be nice too. I'll have a look at stefan's patches for that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33203
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id906733ac3719c8d6835aad52ca87beb81b5771d
Gerrit-Change-Number: 33203
Gerrit-PatchSet: 17
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 10 Nov 2019 12:57:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment